Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624471 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-09-29 05:27:08 EDT --- Source file is original. FIX: License is GPLv3, not a perl-like (verified from Tagger.pm). Summary and Description tags Ok (verified from Tagger.pm). TODO: Consider INSTALLDIRS=perl and %{perl_privlib}/* as this is the place we want to move all perl packages in F15 (just formal issue as real path is identic). FIX: Add perl(File::Spec) >= 0.84 (Build)Requires as the module can be dual-lived (http://search.cpan.org/search?query=File%3A%3ASpec&mode=all) in the future. FIX: Replace perl(HTML::Parser) Requires with versioned perl(HTML::TokeParser) as HTML::TokeParser is used in code. File a bug to upstream to replace perl(HTML::Parser) dependency with perl(HTML::TokeParser) in Makefile.PL. FIX: (Build)Require perl(Momoize) >= 1.01 (used by Tagger.pm, version specified in META.yml) FIX: (Build)Require perl(Storable) >= 2.10 (used by Tagger.pm, version specified in META.yml) as the module can be dual-lived (http://search.cpan.org/search?query=Storable&mode=all) in the future. All tests pass. $ rpmlint perl-Lingua-EN-Tagger.spec ../SRPMS/perl-Lingua-EN-Tagger-0.16-1.fc13.src.rpm ../RPMS/noarch/perl-Lingua-EN-Tagger-0.16-1.fc13.noarch.rpm perl-Lingua-EN-Tagger.spec: W: no-cleaning-of-buildroot %clean perl-Lingua-EN-Tagger.spec: W: no-buildroot-tag perl-Lingua-EN-Tagger.spec: W: no-%clean-section perl-Lingua-EN-Tagger.src: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up perl-Lingua-EN-Tagger.src: W: no-cleaning-of-buildroot %clean perl-Lingua-EN-Tagger.src: W: no-buildroot-tag perl-Lingua-EN-Tagger.src: W: no-%clean-section perl-Lingua-EN-Tagger.noarch: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up 2 packages and 1 specfiles checked; 0 errors, 8 warnings. This is post-F12 spec file (no BuildRoot needed). rpmlint output Ok. TODO: Correct description spelling (use `look-up' as compound adjective). $ rpm -pqlv ../RPMS/noarch/perl-Lingua-EN-Tagger-0.16-1.fc13.noarch.rpm drwxr-xr-x 2 root root 0 zÃÅ 29 11:07 /usr/share/doc/perl-Lingua-EN-Tagger-0.16 -rw-r--r-- 1 root root 1605 kvÄ 11 19:39 /usr/share/doc/perl-Lingua-EN-Tagger-0.16/Changes -rw-r--r-- 1 root root 3633 pro 9 2003 /usr/share/doc/perl-Lingua-EN-Tagger-0.16/README -rw-r--r-- 1 root root 3556 zÃÅ 29 11:07 /usr/share/man/man3/Lingua::EN::Tagger.3pm.gz drwxr-xr-x 2 root root 0 zÃÅ 29 11:07 /usr/share/perl5/Lingua drwxr-xr-x 2 root root 0 zÃÅ 29 11:07 /usr/share/perl5/Lingua/EN drwxr-xr-x 2 root root 0 zÃÅ 29 11:07 /usr/share/perl5/Lingua/EN/Tagger -rw-r--r-- 1 root root 31528 kvÄ 11 19:39 /usr/share/perl5/Lingua/EN/Tagger.pm -rw-r--r-- 1 root root 26267 zÃÅ 29 11:07 /usr/share/perl5/Lingua/EN/Tagger/pos_tags.hash -rw-r--r-- 1 root root 1351373 zÃÅ 29 11:07 /usr/share/perl5/Lingua/EN/Tagger/pos_words.hash -rw-r--r-- 1 root root 23243 lis 13 2003 /usr/share/perl5/Lingua/EN/Tagger/tags.yml -rw-r--r-- 1 root root 441 lis 13 2003 /usr/share/perl5/Lingua/EN/Tagger/unknown.yml -rw-r--r-- 1 root root 977164 lis 14 2003 /usr/share/perl5/Lingua/EN/Tagger/words.yml File permissions and location Ok. $ rpm -pq --requires ../RPMS/noarch/perl-Lingua-EN-Tagger-0.16-1.fc13.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(FileHandle) 1 perl(File::Spec) 1 perl(HTML::Parser) >= 3.45 1 perl(HTML::TokeParser) 1 perl(Lingua::Stem::En) 1 perl(Lingua::Stem) >= 0.81 1 perl(Memoize) 1 perl(Memoize::ExpireLRU) >= 0.55 1 perl(:MODULE_COMPAT_5.10.1) 1 perl(Storable) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 Binary dependencies Ok. $ rpm -pq --provides ../RPMS/noarch/perl-Lingua-EN-Tagger-0.16-1.fc13.noarch.rpm | sort | uniq -c 1 perl(Lingua::EN::Tagger) = 0.16 1 perl-Lingua-EN-Tagger = 0.16-1.fc13 Binary provides Ok. Builds on F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2496256). Spec file in line with packaging guidelines. Please fix all `FIX:' prefixed comments and publish new spec file. Consider `TODO:' prefixed comments. Result: NOT APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review