Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638418 Alexander Kurtakov <akurtako@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akurtako@xxxxxxxxxx --- Comment #2 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2010-09-29 04:20:31 EDT --- I can review this one and sponsor you but I have few comments: 1. If we don't have a clear way where are the sources coming from or how to generate the tarball it's a nogo. 2. Choose only one of the build systems either ant or maven. 3. Always provide a unversioned javadoc and remove these post/postun sections for javadoc. 4. Drop gcj-support - we don't need it nowadays. 5. Ehcache has seen big restructuring - http://svn.terracotta.org/svn/ehcache/tags/ and http://ehcache.org/roadmap.html# and http://oss.sonatype.org/content/repositories/sourceforge-releases/net/sf/ehcache/ehcache/ 6. Update to latest version - 2.2.0 7. Fix file attributes to the defaults for fedora. And this is only from the first sight :). Also if you drop gcj you won't need gnu-crypto. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review