Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629326 --- Comment #17 from Chen Lei <supercyper1@xxxxxxxxx> 2010-09-27 11:05:56 EDT --- Some minor issues: It'll be better to use a mirror URL(e.g. ftp://sunsite.informatik.rwth-aachen.de/pub/mirror/www.mysql.com/Downloads/MySQLGUITools/mysql-workbench-gpl-5.2.28-src.tar.gz) instead of incomplete Source URL, so that we can use spectool to down and verify source file. I also suggest to use vitual provides: libGL-devel instead of mesa-libGL-devel. See rpm -q --whatprovides libGL-devel Is BuildRequires: uuid-devel really needed for mysql-workbench? It seems BR: libuuid-devel is enough for mysql-workbench. BuildRequires: lua-devel can be removed from spec, BuildRequires: lua-devel >= 5.1 is enough. Requires(post): desktop-file-utilsRequires(postun): desktop-file-utils is only need for EPEL 4. See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review