[Bug 605423] Review Request: python-dulwich - A python implementation of the Git file formats and protocols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605423

Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.badger@xxxxxxxxx,
                   |                            |dmalcolm@xxxxxxxxxx

--- Comment #11 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-09-27 08:22:46 EDT ---
(In reply to comment #10)
> Thanks for the new package. It looks good, unfortunately the trick with
> "%global __find_provides %{_rpmconfigdir}/find-provides | grep -v -E
> '_objects.so|_pack.so'" 
> does not work (independently of "-E"):
[snip]
> Usually it is suggested to use an external script (see
> http://fedoraproject.org/wiki/PackagingDrafts/FilteringAutomaticDependencies ).
[snip]
> http://fedoraproject.org/wiki/Common_Rpmlint_issues#private-shared-object-provides
> should be fixed as well - I'll write tomspur a separate mail. ;-)

I just found a far better way to solve this.
There are some macros defined in redhat-rpm-config, see:
http://fedorapeople.org/~cweyl/macros.filtering

With that you can simply do:
%filter_provides_in %{python_sitearch}
%filter_setup

Which works like a charm!
I'll update the wiki to suggest using that instead, because we haven't
automatic provides for python (yet), so we can exclude the pythonpath
completely.
(Might change sometime.)

Because this applies to ALL python-non-noarch packages it would be great if
this would be defined somewhere in the python macros.
This way, no python package needs to do that sort of filtering anymore.

(CC'ing Toshio and David for opionions)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]