Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtk-murrine-engine - Murrine GTK2 engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215224 ------- Additional Comments From sdl.web@xxxxxxxxx 2006-11-21 14:10 EST ------- (In reply to comment #11) > Well, just a quick look at this package. > > A. From http://fedoraproject.org/wiki/Packaging/Guidelines : > * BuildRequires: > - cairo-devel fontconfig-devel freetype-devel > All these are uncessary as gtk2-devel requires them. Corrected with only gtk2-devel. > > * rpmlint > - is not silent. > ---------------------------------------------------------------------- > W: gtk-murrine-engine incoherent-version-in-changelog 0.31 0.31-2.fc7 > ---------------------------------------------------------------------- > Please make version-release consistent. > NOTE: the part of dist tag (i.e. '.fc7') is not needed to be written > in %changelog. Don't know what to do with this. It seems I have no .fc7 in log entries. > > * BuildRoot > - %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is > recommended. corrected. > > * File and Directory Ownership > - /usr/share/themes > is not owned by any packages needed by this package. > * if this package requires gtk2-engines, please add it to Requires. > * if not, please have this package own the directory. > > B. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : > * Source: > - Please specify the URL. Done. > > C. Other things: > > * Themes > - I cannot understand why you chose the 3 themes. I don't think that > 'their popularity' is a good reason because many people (including > me) cannot judge how 'popular' they are. > My thought is that you have to include _all_ themes available to > avoid arbitrariness or choose one (or some) theme(s) with > somewhat definitive reason. > > As far as I read http://cimi.netsons.org/pages/murrine/themes.php , > http://cimi.netsons.org/media/download_gallery/MurrineThemePack.tar.bz2 > seems the best as it says 'First Theme Pack for the > Murrine Gtk2 Cairo Engine' themes from replaced with all Murrine themes from the author's website. > > I only checked for packaging issue. Thank you very much for your input. Updated files: http://www.srcf.ucam.org/~sl392/fedora/SRPMs/gtk-murrine-engine.spec http://www.srcf.ucam.org/~sl392/fedora/SRPMs/gtk-murrine-engine-0.31-3.leofc5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review