Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226500 --- Comment #3 from Parag AN(àààà) <panemade@xxxxxxxxx> 2010-09-27 06:16:11 EDT --- Following are the changes proposed in above patch 1) Generally we used to have dependent packages already built in repo so I guess no need of versioned BuildRequires: and also Requires: See,https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires If this package needs versioned BR: and R: then please add comment in spec file 2) Guidelines shows no need to use versioned scriptlet Requires: needed. https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf 3)Guidelines shows no need of following in spec now as per https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage Requires(post): desktop-file-utils Requires(postun): desktop-file-utils 4) Removal of Obsoletes and Provides is recommended after 2 releases See http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F 5) Guidelines suggests to keep timestamps of upstream installed files. So please use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps 6) Guidelines suggests package built above F-13 do not need %clean See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean 7) Updated scriptlets used as per guidelines suggested a) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Scrollkeeper says "In all current Fedora, rarian has replaced scrollkeeper. There is no scriptlet needed for rarian" b) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database c) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache d) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf 8) Guidelines recommends defattr usage as %defattr(-, root, root,-) See https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review