Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628524 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2010-09-26 10:50:23 EDT --- Koji build for F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2490061 REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is silent Sulaco ~/rpmbuild/SPECS: rpmlint ~/Desktop/festival-freebsoft-utils-0.10-1.fc13.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Sulaco ~/rpmbuild/SPECS: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. +/- The License field in the package spec file does not match the actual license (should be GPLv2+, not simply GPLv2). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. Sulaco ~/rpmbuild/SOURCES: sha256sum festival-freebsoft-utils-0.10.tar.gz* c16cbd1d5494b1b058b787ef936fa483ac2f3ce92657372c92b3dbf153750457 festival-freebsoft-utils-0.10.tar.gz c16cbd1d5494b1b058b787ef936fa483ac2f3ce92657372c92b3dbf153750457 festival-freebsoft-utils-0.10.tar.gz.1 Sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture (see koji link above) + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Just three minor suggestions: * Consider building docs also * Use %{_datadir} macro in the %install section * Fix licensing tag (GPLv2+ instead of GPLv2) This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review