Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636819 Arun SAG <sagarun@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sagarun@xxxxxxxxx --- Comment #1 from Arun SAG <sagarun@xxxxxxxxx> 2010-09-26 06:37:04 EDT --- + = OK - = NA ? = issue + Package meets naming and packaging guidelines + Spec file matches base package name. ? Spec has consistent macro usage. + Meets Packaging Guidelines. + License ? License field in spec matches ? License file included in package + Spec in American English ? Spec is legible. - Sources match upstream md5sum: - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. ? Package has %defattr and permissions on files is good. + Package has a correct %clean section. ? Package has correct buildroot %{_tmppath}/%{name} + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. http://koji.fedoraproject.org/koji/taskinfo?taskID=2489884 + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. ? No rpmlint output. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) XXXXX ISSUES XXXXXX 1. Spec has consistent macro usage. All instances of gnome-exe-thumbnailer can be replaced by %{name} macro 2. License field in spec matches The license is LGPLv2+ 3. License file included in package License file is not included in the package. Ask upstream to include license files in next release. 4. Spec is legible. Provide spaces/lines between %pre,%build,%install tags and %post %preun tags 5. Package has correct buildroot Buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 6. ? No rpmlint output. ------------------------- [zer0c00l@gnubox SPECS]$ rpmlint ~/rpmbuild/RPMS/noarch/gnome-exe-thumbnailer-0.6-0.fc13.noarch.rpm #Fix the spelling gnome-exe-thumbnailer.noarch: W: spelling-error Summary(en_US) thumnailes -> thumbnails, thumbnail, thumbstalls gnome-exe-thumbnailer.noarch: W: spelling-error %description -l en_US py -> pt, p, y #License is LGPLv2+ gnome-exe-thumbnailer.noarch: W: invalid-license LGPL #Remove _executable_ permission from the all other files other than the gnome-exe-thumbnailer.sh file gnome-exe-thumbnailer.noarch: E: script-without-shebang /etc/gconf/schemas/gnome-exe-thumbnailer.schemas gnome-exe-thumbnailer.noarch: W: spurious-executable-perm /usr/share/doc/gnome-exe-thumbnailer-0.6/README Example: ---------- install -pm 755 gnome-exe-thumbnailer.sh $RPM_BUILD_ROOT%{_bindir}/ install -pm 644 gnome-exe-thumbnailer.schemas $RPM_BUILD_ROOT%{_sysconfdir}/gconf/schemas/ install -pm 644 README $RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version}/ install -pm 644 gnome-exe-thumbnailer-template.png $RPM_BUILD_ROOT%{_datadir}/pixmaps/ install -pm 644 gnome-exe-thumbnailer-generic-x.png $RPM_BUILD_ROOT%{_datadir}/pixmaps/ install -pm 644 gnome-exe-thumbnailer-generic.png $RPM_BUILD_ROOT%{_datadir}/pixmaps/ #can be ignored gnome-exe-thumbnailer.noarch: W: no-manual-page-for-binary gnome-exe-thumbnailer.sh #This is Ok you can ignore the below warnings gnome-exe-thumbnailer.noarch: W: dangerous-command-in-%pre rm gnome-exe-thumbnailer.noarch: W: dangerous-command-in-%post rm 1 packages and 0 specfiles checked; 1 errors, 7 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review