Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630204 Thomas Moschny <thomas.moschny@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |thomas.moschny@xxxxxx --- Comment #3 from Thomas Moschny <thomas.moschny@xxxxxx> 2010-09-26 05:23:50 EDT --- Some remarks prior to a full review: * Seems https://fedoraproject.org/wiki/Packaging:Haskell is out of date. It does not mention %ghc_lib_build, %ghc_lib_install or %ghc_lib_package, and has broken links to cvs.fedoraproject.org and also broken links to git.fedorahosted.org. Nevertheless, the specfile is auto-generated, and thus mostly identical to spectemplate-ghc-lib.spec, so I'll assume it's ok. * The aforementioned wiki page says: "When packaging things out of Hackage or other sources, you may find that the summary or description is incomplete or lacks detail. Please try to include an appropriate summary and adequate description for Fedora of the library or program in the package so users will know what it does." This is clearly missing here. Not even all three lines of summary present in Hackage are included in the summary, but even those are a bit thin. * rpmlint says: ghc-mtlparse.x86_64: W: executable-stack /usr/lib64/ghc-6.12.1/mtlparse-0.0.1/libHSmtlparse-0.0.1-ghc6.12.1.so - Could that cause any problems, e.g. with selinux? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review