Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632912 Michal Ambroz <rebus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(rebus@xxxxxxxxx) | --- Comment #4 from Michal Ambroz <rebus@xxxxxxxxx> 2010-09-25 15:49:53 EDT --- Hello Mamoru, thank you for review, here is the updated package: SPEC URL: http://rebus.fedorapeople.org/SPECS/rubygem-robots.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/rubygem-robots-0.10.0-2.fc13.src.rpm I have tried to implement changes based on your comments. Unfortunately I was not able to implement all the changes you have been asking - mainly: * BuildRoot - having this tag is not an error - I would like to keep the package maintained for EPEL5 as well and I would prefer to have 1 spec if possible. * %check - some packages needed for test are not available in Fedora yet (shoulda, jeweler), I have included BuildRequire(check) dependencies and check section, but it is now commented out. I will uncomment as soon as the dependencies are available. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review