Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623604 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |martin.gieseking@xxxxxx Flag| |fedora-review? --- Comment #6 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-24 15:04:07 EDT --- Hi Pavel, thanks for the updates. The package looks almost fine now. Just add %dir %{sysconfdir}/%{name} to the %files section to make the base package own this directory. The following rpmlint messages can be ignored if the zero-length files are going to be updated in a future release. $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm xneur.src: I: enchant-dictionary-not-found ru xneur.x86_64: E: zero-length /usr/share/xneur/languages/es/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/es/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/gr/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/ru/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/lt/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/fr/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/uz/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/am/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/de/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/lt/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/bg/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/fr/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/lv/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/by/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/ua/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/ee/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/ge/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/ua/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/bg/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/uz/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/ee/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/ro/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/cz/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/by/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/lv/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/am/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/cz/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/gr/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/ge/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/de/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/pl/regexp xneur-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 31 errors, 1 warnings. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - GPLv2 according to source file headers [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum xneur-0.9.9.tar.bz2* 3c87012e79838fb57220fe71a16546ce xneur-0.9.9.tar.bz2 3c87012e79838fb57220fe71a16546ce xneur-0.9.9.tar.bz2.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Koji scratch build for F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2487627 [.] MUST: If the package does not successfully compile, ... [+] MUST: All build dependencies must be listed in BuildRequires. [+] MUST: The spec file MUST handle locales properly. [+] MUST: Packages storing shared libraries must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [X] MUST: A package must own all directories that it creates. - the base package doesn't own %{sysconfdir}/%{name} [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [+] MUST: library files that end in .so must go in a -devel package. [+] MUST: devel packages must require the base package using a fully versioned dependency [+] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s)... [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. - seems to work as expected [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: subpackages other than devel should require the base package [+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, ... [+] SHOULD: your package should contain man pages for binaries/scripts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review