Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636945 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-09-24 07:11:01 EDT --- Source tar ball is original. License verified from lib/Convert/UU.pm. FIX: Summary text does not end with full stop. FIX: BuildRequires perl(Exporter) (check-time) missing. This is needed because Exporter package could be dual-life in the future (http://search.cpan.org/search?query=Exporter&mode=all). TODO: Remove unneeded BuildRoot tag as this is obviously post-F12 spec (no %clean section). TODO: Report bad interpreter path in puudecode to upstream. FIX: Remove puudecode puuencode from %doc (effectively same as in %{_bindir}) FIX: Package %{perl_privlib}/* instead of %{perl_vendorlib}/* (INSTALLDIRS=perl) All tests pass. $ rpmlint perl-Convert-UU.spec ../SRPMS/perl-Convert-UU-0.5201-1.fc13.src.rpm ../RPMS/noarch/perl-Convert-UU-0.5201-1.fc13.noarch.rpm perl-Convert-UU.spec: W: no-cleaning-of-buildroot %clean perl-Convert-UU.spec: W: no-%clean-section perl-Convert-UU.src: W: spelling-error Summary(en_US) uuencode -> encoder, encode, Unicode perl-Convert-UU.src: W: spelling-error Summary(en_US) uudecode -> Unicode, undecided, decoupage perl-Convert-UU.src: W: spelling-error %description -l en_US uuencode -> encoder, encode, Unicode perl-Convert-UU.src: W: spelling-error %description -l en_US uudecode -> Unicode, undecided, decoupage perl-Convert-UU.src: W: no-cleaning-of-buildroot %clean perl-Convert-UU.src: W: no-%clean-section perl-Convert-UU.noarch: W: spelling-error Summary(en_US) uuencode -> encoder, encode, Unicode perl-Convert-UU.noarch: W: spelling-error Summary(en_US) uudecode -> Unicode, undecided, decoupage perl-Convert-UU.noarch: W: spelling-error %description -l en_US uuencode -> encoder, encode, Unicode perl-Convert-UU.noarch: W: spelling-error %description -l en_US uudecode -> Unicode, undecided, decoupage 2 packages and 1 specfiles checked; 0 errors, 12 warnings. rpmlint ouptut is Ok. $ rpm -pq --requires ../RPMS/noarch/perl-Convert-UU-0.5201-1.fc13.noarch.rpm | sort |uniq -c 1 perl(Carp) 1 perl(Convert::UU) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.10.1) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 1 /usr/bin/perl Binary dependencies Ok. $ rpm -pq --provides ../RPMS/noarch/perl-Convert-UU-0.5201-1.fc13.noarch.rpm | sort |uniq -c 1 perl(Convert::UU) = 0.5201 1 perl-Convert-UU = 0.5201-1.fc13 Binary provides Ok. $ rpm -pqlv ../RPMS/noarch/perl-Convert-UU-0.5201-1.fc13.noarch.rpm -rwxr-xr-x 1 root root 1010 zÃÅ 24 12:35 /usr/bin/puudecode -rwxr-xr-x 1 root root 980 zÃÅ 24 12:35 /usr/bin/puuencode drwxr-xr-x 2 root root 0 zÃÅ 24 12:35 /usr/share/doc/perl-Convert-UU-0.5201 -rw-r--r-- 1 root root 2341 bÅe 2 2008 /usr/share/doc/perl-Convert-UU-0.5201/ChangeLog -rw-r--r-- 1 root root 1870 bÅe 2 2008 /usr/share/doc/perl-Convert-UU-0.5201/README -rw-r--r-- 1 root root 925 zÃÅ 24 12:35 /usr/share/doc/perl-Convert-UU-0.5201/puudecode -rw-r--r-- 1 root root 895 bÅe 2 2008 /usr/share/doc/perl-Convert-UU-0.5201/puuencode -rw-r--r-- 1 root root 2016 zÃÅ 24 12:35 /usr/share/man/man1/puudecode.1.gz -rw-r--r-- 1 root root 2033 zÃÅ 24 12:35 /usr/share/man/man1/puuencode.1.gz -rw-r--r-- 1 root root 2594 zÃÅ 24 12:35 /usr/share/man/man3/Convert::UU.3pm.gz drwxr-xr-x 2 root root 0 zÃÅ 24 12:35 /usr/share/perl5/Convert -rw-r--r-- 1 root root 5332 bÅe 2 2008 /usr/share/perl5/Convert/UU.pm File permissions and location Ok. Spec file in line with Perl packaging guidelines. FIX: Does not builds on F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2486640). FIX: Add BuildRequires necessary for %check phase: perl(File::Spec), perl(Test::More), perl(Test::Pod) >= 1.00, perl(Test::Pod::Coverage). Please fix all `FIX:' prefixed comments and publish new spec file. Result: NOT APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review