Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626446 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |martin.gieseking@xxxxxx Flag| |fedora-review? --- Comment #5 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-23 14:41:58 EDT --- Hi Peter, the package looks good. There are just some (minor) cosmetic things: - I suggest to replace the Summary with: Minisip library providing various C++ utility classes - I'd also prefer a complete sentence in the %description the -devel package: This package contains the development files for library %{name}. - Remove the DOS line endings from the example sources, e.g. with for f in examples/*; do sed "s|\r||g" $f > $f.new touch -r $f $f.new mv $f.new $f done $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm libmutil.src: W: spelling-error %description -l en_US mutexes -> mut exes, mut-exes, muteness libmutil.src: W: spelling-error %description -l en_US minisip -> mini sip, mini-sip, miniskirt libmutil.src: W: invalid-url Source0: libmutil-0.8.0.tar.bz2 libmutil.x86_64: W: spelling-error %description -l en_US mutexes -> mut exes, mut-exes, muteness libmutil.x86_64: W: spelling-error %description -l en_US minisip -> mini sip, mini-sip, miniskirt libmutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libmutil.so.0.0.0 exit@xxxxxxxxxxx libmutil-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libmutil-0.8.0/libltdl/.libs libmutil-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libmutil-0.8.0/libltdl/.libs libmutil-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libmutil-devel-0.8.0/threadtest.cpp libmutil-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libmutil-devel-0.8.0/mutextest.cpp libmutil-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libmutil-devel-0.8.0/semaphoretest.cpp 4 packages and 0 specfiles checked; 0 errors, 11 warnings. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - LGPLv2 (and GPLv2 for a single file in -devel) [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. - COPYING.LIB added - tarball doesn't contain text of GPLv2 [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ diff -qr a/libmutil-0.8.0 b/libmutil-0.8.0 (no output) [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [+] MUST: Packages storing shared library files must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [+] MUST: .so (without suffix) must go in a -devel package. [+] MUST: devel packages must require the base package. [+] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [X] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. - the GPLv2 license text should be added to the tarball [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: subpackages other than devel should require the base package. [+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [.] SHOULD: your package should contain man pages for binaries/scripts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review