Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635654 --- Comment #2 from Paul Howarth <paul@xxxxxxxxxxxx> 2010-09-21 06:09:14 EDT --- (In reply to comment #1) > Suggestions > 1) If there are no plans to add this package < F13 releases then please > a) remove buildroot > b) remove cleaning of buildroot in %install > c) remove %clean section I plan to build it for F-12. These items can be removed once it goes EOL. > 2) Is versioned BR: needed in this package? > hunspell-devel >= 1.2.8 > If not then please remove it. The package won't work with earlier versions of hunspell. Adding the versioned dependency makes it clear that the package won't work with (say) EPEL 4 and 5. Thanks for the review Parag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review