[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635515

--- Comment #3 from Rich Mattes <richmattes@xxxxxxxxx> 2010-09-20 20:48:55 EDT ---
Thanks for taking on the review!

I've enabled zeroconf, zeroconf-lookup, and am now using the ldconfig switch. 
I added the patch to keep the buildsystem from trying to rm old versions of
itself, and commented out the ldconfig stuff cause i was already in there. 
I've dropped the patches (and the calls to aclocal and libtoolize.)  I've also
installed the udev rules.  

--enable-jni didn't seem to do anything, but I did a little digging and the
.jar file has a separate make target.  I've enabled it and installed the .jar
file to the jnidir.  I'm not really sure what to do with the resulting .jar
file: the packaging guidelines say that the .jar file should be installed in
%{_libdir}/%{name}, but then it goes on to outline the %{_jnidir}.  I've put
the .jar in the jnidir for now.  If it's wrong, I'll fix or remove it.

Spec URL: http://rmattes.fedorapeople.org/RPMS/libphidget/libphidget.spec
SRPM URL:
http://rmattes.fedorapeople.org/RPMS/libphidget/libphidget-2.1.7.20100621-2.fc13.src.rpm 


$ rpmlint ../RPMS/x86_64/libphidget-* ../SRPMS/libphidget*
libphidget.x86_64: W: spelling-error %description -l en_US Phidgets -> Fidgets,
Midgets, Widgets
libphidget-devel.x86_64: W: no-documentation
libphidget.src: W: spelling-error %description -l en_US Phidgets -> Fidgets,
Midgets, Widgets
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]