Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635453 Mark McKinstry <mmckinst@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmckinst@xxxxxxxxxxx --- Comment #1 from Mark McKinstry <mmckinst@xxxxxxxxxxx> 2010-09-19 23:34:12 EDT --- FranÃois, A few comments: 1. The license should be GPLv3+ 2. You could replace the setup and prep sections with just ''%setup -q -n %{name}-%{name}-88674c3' 3. In the build section, it should just be 'make' otherwise rpmlint in unhappy with the unstripped binary 4. In the files section, you should specify the binary as '%{_bindir}deafshell' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review