Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635256 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #4 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-09-19 13:56:42 EDT --- A few comments from an everyday batch system user. The Requires: torque should read Requires: torque-client as the queue tools are in that package. I'm not totally sure if the Requires is necessary or if a meta-require should be placed, but on the other hand I can't come up with any other PBS queue system than torque, so it's probably OK. Furthermore, you need to do some patching for the colormap file. There seems to be a bug in qtop, since it downloads the colormap to the home directory before checking if there is a colormap in /etc. It's probably best to keep the option for the user to have his/her own colormap, so you'll probably want to rearrange lines 163-170 in qtop. You might want to report this upstream. Third, you need to place lines 32-60 in /etc/qtop.conf (mark this as config(noreplace)), as those lines contain configuration options that users might want to change. First of all having them in the "binary" is kind of sick, and second if users change the contents the changes will be lost whenever an upgrade is performed. Be sure to make a comment line in qtop indicating the correct location to make any changes in. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review