Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635256 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-19 07:39:16 EDT --- Hi Fotis, as I can't find you in FAS, this is probably your first package submission. If so, please add FE-NEEDSPONSOR to the Blocks field above, and see http://fedoraproject.org/wiki/PackageMaintainers/Join for further details. Here are some initial notes on your package: - the version number should not contain any letters - add %{?dist} to the Release number - shorten the Summary to "Monitoring tool for PBS-based cluster systems" (the package name and leading articles should be avoided in the summary) - the license seems to be GPLv2 (update the License field accordingly) http://fedoraproject.org/wiki/Licensing#SoftwareLicenses - the SF project URL is invalid - the %description lines should not exceed 80 characters - add an empty %build section with a comment "nothing to build" - drop the commented/disabled shell commands - use macros to refernce system directories in %install and %files /etc -> %{_sysconfdir} - Unlike stated in the header comment of qtop, the source tarball doesn't contain the GPLv2 license text. Since you're the upstream developer, you should add it. :) - the %changelog headers should contain the email address of the packager (see http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs) $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm qtop.noarch: W: summary-not-capitalized C qtop, a monitoring tool for PBS-based cluster systems qtop.noarch: W: name-repeated-in-summary C qtop qtop.noarch: W: spelling-error %description -l en_US ascii -> ASCII, asci, asci i qtop.noarch: W: spelling-error %description -l en_US ansi -> ANSI, anis, ans qtop.noarch: W: spelling-error %description -l en_US devided -> decided, devised, divided qtop.noarch: W: spelling-error %description -l en_US qstat -> stat, q stat, States qtop.noarch: W: spelling-error %description -l en_US eg -> Eg, eh, e qtop.noarch: E: description-line-too-long C It tries to fit as much as possible information in a single screen's real estate. qtop.noarch: E: description-line-too-long C The screen is devided in three sections, reporting a) Summary b) Cores matrix c) Users qtop.noarch: E: description-line-too-long C Each user gets mapped to a unique letter, according to their number of jobs in qstat. qtop.noarch: E: description-line-too-long C Character 0 is always the user with the most R+Q+other jobs, 1 is next in # of jobs etc. qtop.noarch: E: description-line-too-long C qtop should suppress color mode automatically, when needed, eg. try: watch -d qtop qtop.noarch: E: description-line-too-long C It is very configurable, read first part of source code for how to make your qtop.conf qtop.noarch: W: incoherent-version-in-changelog v40 ['v40-1', 'v40-1'] qtop.noarch: W: invalid-license GPL qtop.noarch: W: invalid-url URL: http://qtop.sf.net HTTP Error 404: Not Found qtop.noarch: W: no-documentation qtop.noarch: W: non-conffile-in-etc /etc/qtop.colormap qtop.noarch: W: no-manual-page-for-binary qtop qtop.src: W: summary-not-capitalized C qtop, a monitoring tool for PBS-based cluster systems qtop.src: W: name-repeated-in-summary C qtop qtop.src: W: spelling-error %description -l en_US ascii -> ASCII, asci, asci i qtop.src: W: spelling-error %description -l en_US ansi -> ANSI, anis, ans qtop.src: W: spelling-error %description -l en_US devided -> decided, devised, divided qtop.src: W: spelling-error %description -l en_US qstat -> stat, q stat, States qtop.src: W: spelling-error %description -l en_US eg -> Eg, eh, e qtop.src: E: description-line-too-long C It tries to fit as much as possible information in a single screen's real estate. qtop.src: E: description-line-too-long C The screen is devided in three sections, reporting a) Summary b) Cores matrix c) Users qtop.src: E: description-line-too-long C Each user gets mapped to a unique letter, according to their number of jobs in qstat. qtop.src: E: description-line-too-long C Character 0 is always the user with the most R+Q+other jobs, 1 is next in # of jobs etc. qtop.src: E: description-line-too-long C qtop should suppress color mode automatically, when needed, eg. try: watch -d qtop qtop.src: E: description-line-too-long C It is very configurable, read first part of source code for how to make your qtop.conf qtop.src: W: invalid-license GPL qtop.src: W: invalid-url URL: http://qtop.sf.net HTTP Error 404: Not Found qtop.src:11: W: macro-in-comment %{_tmppath} qtop.src:11: W: macro-in-comment %{name} qtop.src:11: W: macro-in-comment %{version} qtop.src:11: W: macro-in-comment %{release} qtop.src:11: W: macro-in-comment %{__id_u} qtop.src:32: W: macro-in-comment %_sourcedir qtop.src:32: W: macro-in-comment %_sourcedir qtop.src:33: W: macro-in-comment %{_sourcedir} qtop.src:46: W: macro-in-comment %{buildroot} qtop.src: W: no-%build-section 2 packages and 0 specfiles checked; 12 errors, 32 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review