Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633333 Mark McKinstry <mmckinst@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmckinst@xxxxxxxxxxx --- Comment #6 from Mark McKinstry <mmckinst@xxxxxxxxxxx> 2010-09-18 21:35:33 EDT --- A few suggestions and questions: 1. Is there an upstream website or provider for this package? Generally Fedora isn't the place to submit or maintain personal code. 2. Take out the line that says '# This is a sample spec file for wget' 3. The macros for name, release, and version aren't necessary. You should define those in their respective lines 'Name', 'Release', 'Version'. 4. Your buildroot is specific to your file system and won't work on others which don't have that directory. You should use http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag as your buildroot 5. The 'Source' line should be a link to download the code. 6. The license should be GPLv2, not GPL. That's it for the top part of the SPEC. I can help you with the rest of it but I'm not sure how well it will fit in to Fedora if its original code you wrote and have never released or posted anywhere. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review