Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623604 --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-18 12:16:42 EDT --- Hi Pavel and Damian (In reply to comment #1) > NOT OK. > The summary attempts to compare this program to a different one: > "It's program like Punto Switcher, ..." > which should be avoided[2]. BTW, for people who don't know what the > Punto Switches program is designed for, such a comparison is rather useless. I agree here. I suggest to use a slightly shortened paragraph from Wikipedia, for example: X Neural Switcher is a program for automatic (intelligent) keyboard layout changing in the X Window System. It is mainly used to change between Russian and English, but also supports Ukrainian, Belorussian, French, Romanian, Kazakh and German. > - MUST: Packages must NOT OK bundle copies of system libraries. > > NOT OK. > It looks that it the xneur library needs to be packaged separately[4]. It's OK to put libraries that are an original part of the program into the same package as the program (here: xneur and libxneur). Nonetheless, it might be useful to put the library in a subpackage to avoid conflicts in multilib environments (where the 32bit and 64bit version of the library are installed). But this is up to the packager. > - MUST: A package must own all directories that it creates. If it does not > create a directory that it uses, then it should require a package which does > create that directory. > NOT OK. > It looks that the package doesn't own all necessary directories > (/usr/lib/xneur)[5]. Right. Add "%dir %{_libdir}/xneur" to the base package to make the package own this directory. Also, replace "%{includedir}/xneur/*" with "%{includedir}/xneur/". It adds the directory plus its contents. > Just please consider to replace %{_libdir}/xneur/*.so.* > with the %{_libdir}/%{name}/*.so.* Both variants %{_libdir}/%{name}/*.so.* and %{_libdir}/xneur/*.so.* are fine. It's not necessary to exaggerate the use of macros. Escpecially %{name} is optional. But if %{name} is favored in %files, it should be used consistently, i.e. xneur and %{name} should not be mixed. Here are some more notes: - BR: autoconf, automake, and libtool are not required and should be removed - libxnconfig and xneur contain rpaths (see rpmlint output below). The rpath must be removed. http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath - I recommend to be more specific in %files to avoid packaging unwanted files: %{_bindir}/xneur %{_mandir}/man1/xneur.1* %{_mandir}/man5/xneurrc.5* $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm xneur.src: I: enchant-dictionary-not-found ru xneur.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libxnconfig.so.9.0.9 ['/usr/lib64'] xneur.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/xneur ['/usr/lib64'] xneur.x86_64: E: zero-length /usr/share/xneur/languages/es/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/es/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/gr/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/ru/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/lt/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/fr/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/uz/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/am/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/de/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/lt/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/bg/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/fr/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/lv/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/by/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/ua/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/ee/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/ge/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/ua/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/bg/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/uz/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/ee/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/ro/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/cz/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/by/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/lv/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/am/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/cz/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/gr/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/ge/regexp xneur.x86_64: E: zero-length /usr/share/xneur/languages/de/dict xneur.x86_64: E: zero-length /usr/share/xneur/languages/pl/regexp xneur-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 33 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review