Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629332 --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-17 03:26:38 EDT --- Hi Marco, thanks for the update. The package looks much better now. Here are some more notes: - In the latest upstream release, the copyright notice in the source files has changed to GPLv2+, i.e. the text "or (at your option) any later version" was added. Thus, you should update the License field accordingly. - "Requires: autoconf" is still present - drop the "echo" statement in %prep to avoid redundant output - Also, it's sufficient to use "%setup -q", as option "-n %{name}-%{version}" is the default - In the %changelog, replace "%build" with "%%build" to make rpmlint happy $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm goaccess.src:54: W: macro-in-%changelog %build goaccess.src: W: invalid-url Source0: http://downloads.sourceforge.net/goaccess/goaccess-0.3.2.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review