Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632554 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|supercyper1@xxxxxxxxx |a.badger@xxxxxxxxx Flag|fedora-review? |fedora-review+ --- Comment #3 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2010-09-16 23:24:51 EDT --- Good: * Package named according to the packaging guidelines * Spec matches package name * License is ZPLv2.1 in source and spec * License file included in doc * spec file readable * Source matches upstream * No locale specific files * Not a shared library * No bundled libraries * Not relocatable * Owns the files and direectories it creates and nothing more * Permissions set properly * Consistent use of macros * code, not content. * Not a GUI * All filenames UTF-8 * builds in koji NEEDSWORK: * Documentation *.txt files in the module directory. These should go to %docdir rpmlint: python-zope-component.src: W: no-cleaning-of-buildroot %install python-zope-component.src: W: no-cleaning-of-buildroot %clean python-zope-component.src: W: no-buildroot-tag python-zope-component.src: W: no-%clean-section 2 packages and 0 specfiles checked; 0 errors, 4 warnings You've been moving the *.txt files to %doc fine in the other zope packages so I'll approve this and you can move them to %docdir when you import. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review