Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632808 --- Comment #6 from Robin Lee <robinlee.sysu@xxxxxxxxx> 2010-09-16 00:56:37 EDT --- (In reply to comment #5) > (In reply to comment #4) > > * About python-setuptools requirement > $ rpmdev-extract python-zope-schema*noarch.rpm > $ cd python-zope-schema*/usr/lib/python2.?/site-packages > $ python > >>> import zope.schema > >>> ^D > $ sudo rpm -e --nodeps python-setuptools > $ python > >>> import zope.schema > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > File "zope/schema/__init__.py", line 16, in <module> > from zope.schema._field import Field, Container, Iterable, Orderable > File "zope/schema/_field.py", line 22, in <module> > from zope.event import notify > ImportError: No module named event I can't reproduce this. [cheese@cheese-laptop site-packages]$ rpm -qa python-zope\* python-zope-testing-3.10.0-2.fc14.noarch python-zope-exceptions-3.6.1-4.fc14.noarch python-zope-event-3.5.0.1-4.fc14.noarch python-zope-interface-3.6.1-3.fc14.i686 [cheese@cheese-laptop site-packages]$ rpm -q python-setuptools package python-setuptools is not installed [cheese@cheese-laptop site-packages]$ python Python 2.7 (r27:82500, Jul 26 2010, 18:19:50) [GCC 4.5.0 20100716 (Red Hat 4.5.0-3)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import zope.schema Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: No module named schema >>> [cheese@cheese-laptop site-packages]$ pwd /home/cheese/rpmbuild/RPMS/noarch/python-zope-schema-3.6.4-2.fc14.noarch/usr/lib/python2.7/site-packages [cheese@cheese-laptop site-packages]$ sudo rpm -Uvh /home/cheese/rpmbuild/RPMS/noarch/python-zope-schema-3.6.4-2.fc14.noarch.rpm Preparing... ########################################### [100%] 1:python-zope-schema ########################################### [100%] [cheese@cheese-laptop site-packages]$ python Python 2.7 (r27:82500, Jul 26 2010, 18:19:50) [GCC 4.5.0 20100716 (Red Hat 4.5.0-3)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import zope.schema >>> The module can be successfully imported without python-setuptools installed. > > > * About tests inclusion > I'm not too keen on including tests when they're bigger than the code that > drives the package. However, tests are something that I can consider cosmetic > except.... OK. I accept this. I will exclude the tests of this and later packages. > > > * About the text files in the module directory. > The text files in this package are documentation. They must be marked as > documentation and put into %{_docdir}. The tests rely on the text, so it seems > strange to leave the tests in the module directory when the text files that > they need have been moved where the tests can't find them. OK. I accept this. And will arrange the text files properly in this and later packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review