Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470696 --- Comment #71 from Benjamin Kosnik <bkoz@xxxxxxxxxx> 2010-09-15 14:10:28 EDT --- In regards to #62, from my analysis of the modified boost diff, the major sticking point is the hack to boost::thread_exception. I suggest a different error handling design. Instead of making thread_exception into what phusion passenger wants, derive oxt::traceable_thread_exception from the un-molested boost::thread_exception and your custom tracing bits add your changes there. This will cleanly separate out the client code (phusion passenger) from the library code (boost), remove the need to deal with upstream boost, help with packaging your software by removing your need to ship a custom boost, and allow you to use C++0x threads in the future. Win, win, win. Please consider it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review