Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630822 Mark McKinstry <mmckinst@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmckinst@xxxxxxxxxxx --- Comment #1 from Mark McKinstry <mmckinst@xxxxxxxxxxx> 2010-09-14 20:01:55 EDT --- Ralph, Since this your first package, you should set FE-NEEDSPONSOR as a blocking bug. You'll want want to read the guide on how to become a package maintainer http://fedoraproject.org/wiki/PackageMaintainers/Join as well as a the package guidelines http://fedoraproject.org/wiki/Packaging/Guidelines and the ones specific to python https://fedoraproject.org/wiki/Packaging:Python I am not a package sponsor but can help you with making your package meet the guidelines. My suggestions are: * At the top of your spec you have macros for RHEL 3 which isn't needed for Fedora. If you're interested in making packages for RHEL, EPEL has packages for RHEL 4 and 5 but not 3. AFAIK RHEL 3 comes with python 2.2 and not python 2.3 too. Anyways, to make this package work on Fedora <= 12 and RHEL <= 5 you can use this, which might work on RHEL 3 (https://fedoraproject.org/wiki/Packaging:Python#Macros) %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif * In the description and summary, you should capitalize ANSI in 'with ansi color codes…' * In the install - don't test if buildroot exists, just remove it. If it exists, it will be removed - if it doesn't, no harm is done. * In the install - you can add --skip-build and leave out --prefix=/usr * In the files section, you need to include the LICENSE in a %doc section * In the files section, you should change the egg section to '%if 0%{?fedora} >= 9 || 0%{?rhel} >= 6' (http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns) * In the files section you don't need to specify the directories. You can just do the following: %{python_sitelib}/ansi2html/*.py* %{python_sitelib}/ansi2html/templates/*.html * You should choose one style of macros and stick with it. You switch between $RPM_BUILD_ROOT and %{buildroot}. Either one is fine as long as your consistent -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review