Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633104 Mark McKinstry <mmckinst@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmckinst@xxxxxxxxxxx --- Comment #1 from Mark McKinstry <mmckinst@xxxxxxxxxxx> 2010-09-13 22:14:42 EDT --- Bernie, A few comments: * You should add a dist tag: http://fedoraproject.org/wiki/Packaging/DistTag * You should add 'BuildArch: noarch' since no binary is built * The build section doesn't do anything, you can leave it out * You need need to include COPYING in which is in the tarball * You should use %defattr(-, root, root, -) instead of %defattr(-, root, root, 755) * A lot of the permissions on the files are weird which rpmlint complains about. For example, the man pages are 755. The man pages can be fixed by replacing the man page lines in the %files section with '%attr(0644, root, root) %{_mandir}/*/*' but looking through some more of the rpmlint errors and warnings it might be easier to patch the Makefile to fix the rest of them. Here's the rpmlint output after making the above modifications including the man page permission fix: [mmckinst@fedora13 rpmbuild]$ rpmlint ~/rpmbuild/RPMS/noarch/monkeysphere-0.31-1.noarch.rpm monkeysphere.noarch: E: non-standard-executable-perm /usr/share/monkeysphere/transitions/0.28 0744L monkeysphere.noarch: W: non-standard-uid /var/lib/monkeysphere monkeysphere monkeysphere.noarch: W: non-standard-gid /var/lib/monkeysphere monkeysphere monkeysphere.noarch: E: non-standard-dir-perm /var/lib/monkeysphere 0775L monkeysphere.noarch: W: non-standard-uid /var/lib/monkeysphere/authorized_keys monkeysphere monkeysphere.noarch: W: non-standard-gid /var/lib/monkeysphere/authorized_keys monkeysphere monkeysphere.noarch: E: non-standard-dir-perm /var/lib/monkeysphere/authorized_keys 0775L monkeysphere.noarch: E: non-standard-executable-perm /usr/share/monkeysphere/transitions/0.23 0744L monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/transitions/0.28 /bin/bash monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/transitions/0.23 /bin/bash monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(Digest::SHA) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/checkperms /usr/bin/perl monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans /usr/bin/perl monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/checkperms perl(File::Basename) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(File::Basename) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(Crypt::OpenSSL::RSA) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/checkperms perl(Cwd) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(bytes) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(Digest::MD5) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/checkperms perl(File::stat) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(warnings) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(POSIX) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(Crypt::OpenSSL::Bignum) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/checkperms perl(strict) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(strict) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/checkperms perl(User::pwent) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(Crypt::OpenSSL::Bignum::CTX) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/checkperms perl(Fcntl) monkeysphere.noarch: W: doc-file-dependency /usr/share/monkeysphere/keytrans perl(MIME::Base64) monkeysphere.noarch: W: dangerous-command-in-%postun userdel 1 packages and 0 specfiles checked; 4 errors, 26 warnings. [mmckinst@fedora13 rpmbuild]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review