Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631190 --- Comment #2 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> 2010-09-13 14:50:45 EDT --- (In reply to comment #1) Thanks for the valuable comments. > - Remove the article "An" and the final dot from the Summary. It's just a > convention to keep the summary concise. done > - add short comments to the spec file telling what the patches do done > - drop "Requires: libusb" as rpm automatically adds it as a dependency done > - You must ensure that the binaries are built with CCFLAGS='%{optflags}' (the > cross-compiled flash binary is an exception). Unfortunately, scons doesn't > seem to accept variable definitions given as command-line arguments. Thus, > you have to patch them into SConstruct. done Spec URL: http://theowned.net/~dw/projects/rpmbuild/SPECS/libnxt.spec SRPM URL: http://theowned.net/~dw/projects/rpmbuild/SRPMS/libnxt-0.3-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review