Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gq - Graphical LDAP directory browser and editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190213 fedora@xxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2006-11-19 13:12 EST ------- (In reply to comment #14) > Updated to gq-1.2.1, I did this some time ago, but something is this version > broke the install of po files. I was waiting for upstream do a new release. You need to copy LINGUAS from gq-%{version}-langpack-1/po to the main packages po dir before compiling, e. g. like this: # Set up langpack %{name}-%{version}-langpack-1/langpack . %{__cp} -p %{name}-%{version}-langpack-1/po/LINGUAS po/ ... Then re-add %find_lang and %files -f %{name}.lang to the spec. Some more things I'd like to you to fix, before I do the complete review: - Please BuildRequire "perl(XML::Parser)" instead of perl-XML-Parser (better user the name of the perl module than the hardcoded package name) - duplicate BuildRequires: gtk2-devel and libxml2-devel are already required by libglade2-devel. - no need to run /sbin/ldconfig in %post, we don't have no shared libs here - please use the scriptlets from the wiki for update-mime-database, see http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-5f93ed83c968bb73b052c06ba0d7139e28f35d93 If you are "stealing" something (your own words from changelog), why not steal from the wiki? ;) - The icon is missing, at least here on Core 6. "redhat-system-tools" is outdated, now it's "redhat-system_tools" (note the underscore). - Don't add the category X-Fedora to gq.desktop, it's not necessary any longer. In fact it never was. - Minor: Can you make your desktop file look more like the upstream one? I'd like to see the multilingual names and comments included. - Minor: you could simplify the %files section a little more, e.g. you could replace %{_datadir}/%{name}/%{name}.glade and %dir %{_datadir}/%{name} with a single "%{_datadir}/%{name}/". This is ok as long as all files in the dir should be owned by gq, which is the case for %{_datadir}/%{name} and %{_datadir}/pixmaps/%{name}. If you however prefer a more detailed listing this is ok too, it will prevent you from accidentally packaging unwanted files. - Minor: Although your defattr is valid I suggest you use "%defattr(-,root,root,-)" instead. This is FE default and looks cleaner. You can also remove the superfluous macros: "%{__make}" "%{__install}" or "%{__rm}" or don't have a practical benefit over make, install or rm. - Minor: Please fix the last changelog entry: Nov 12th was Sun, not Sat. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review