Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632912 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-09-12 14:15:47 EDT --- Some notes: * %define -> %global - Now we prefer to use %global instead of %define: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * BuildRoot - BuildRoot tag is no longer used on Fedora and EPEL6: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * ruby(abi) Requires - Writing "R: ruby(abi) = 1.8" is a must https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * Requires - R: rubygem(shoulda) is not needed - thoughtbot-shoulda (not shoulda) dependency appeas in installed gemspec, however this is for development dependency and is not needed on runtime. * Duplicate %files entry ---------------------------------------------------------------- 58 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/CHANGELOG 59 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/README ---------------------------------------------------------------- - Please make it sure that all files are listed only once in %files entry. ! Note The %files entry ---------------------------------------------------------------- %files /some_dir/ ---------------------------------------------------------------- contains the directory /some_dir/ itself and all files/directories/etc under /some_dir/ , while ---------------------------------------------------------------- %files %dir /some_dir/ ---------------------------------------------------------------- contains the directory /some_dir/ only. * rpmlint issue ---------------------------------------------------------------- rubygem-robots.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/test/test_robots.rb 0644L /usr/bin/env ---------------------------------------------------------------- - This script need not have shebang and the shebang should be removed. * %check - As this gem contains test/ directory, please add %check section and execute some test program there ! Note To make "$ rake test" succeed, some modification against Rakefile is needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review