Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632970 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pikachu.2014@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pikachu.2014@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2010-09-12 06:13:51 EDT --- Hi, some comments to start: 1) be careful with the release: since the sources are taken from a VCS, the Release tag should look like: Release: 0.1.20100821bzr ("1" corresponds to the "release number increment", "20100821" to the date of the last commit in the bazaar repo and "bzr" to the VCS used by upstream). See for more details: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PreReleasePackages 2) In Summary, the dash in "GNOME-desktop" is useless maybe 3) I don't think gstreamer-java is really required 4) In %description, maybe you should remove the reference to MP3 in the list of supported formats... Dont forget also a dot at the end of the description 5) DON'T use CFLAGS to set additional linker flags. You'd better use LDFLAGS: export LDFLAGS=" -lm" %configure make %{?_smp_mflags} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review