Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630208 Dave Ludlow <dave@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review?, needinfo+ |fedora-review+ --- Comment #3 from Dave Ludlow <dave@xxxxxxxxxx> 2010-09-11 17:08:47 EDT --- (In reply to comment #2) > The strange permissions are a relic of my umask of 027. When put into git and > the lookaside, they get the proper 644 (git only tracks +x or -x and the > lookaside has 644). Git and lookasides are nice, but from a package review standpoint I'm only interested in the file permissions that wind up on user's hard drives. I find no suitable guidance in the FHS at http://www.pathname.com/fhs/ Looking at https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions tells me that only file permissions must be set "properly." I cannot think of any realistic instance where this would cause improper behavior and it can only affect developers in any event, so I'll concede that it's a style issue instead of "improper." I'd prefer to see you reset the tarball and .spec file permissions to "typical" 0644 values before building the package, but I won't block on it. > > [-] MUST: The spec file for the package MUST be legible. I just stumbled upon https://fedoraproject.org/wiki/Packaging:Haskell and it satisfies my concerns. I would prefer to see that link as a comment within the .spec file, but I won't block on it either. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review