Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618354 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-09 13:29:19 EDT --- I agree with Ralph's comments. Germán, if you plan to maintain this package for EPEL too, you must clean the buildroot at the beginning of %install. Otherwise, it's not necessary and you can also remove the BuildRoot tag. (In reply to comment #1) > [X] SHOULD: The reviewer should test that the package functions as described. > And a window with no fonts displayed. > I am not into GTK enough to decide if this is not supposed to work in mock, > or something that needs to be fixed. That's OK. mock doesn't install xorg packages and fonts by default. Thus, GUI applications usually don't work in a mock chroot. Two additional remarks: - drop the the following lines from the %description as they don't really relate to the binary package to be built: * MS Windows support, using bsetroot from the Blackbox for Windows project. * A GTK and FLTK version. - I suggest to add a desktop icon to the package. You can download one at http://manualinux.my-place.us/cwallpaper.html (You should ask the author whether it's free and may be used in Fedora.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review