Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mirage - A fast and simple image viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From panemade@xxxxxxxxx 2006-11-19 02:01 EST ------- Review: + package builds in mock (development i386) for FC7. + rpmlint is silent for RPM and SRPM. + source files match upstream. c87da5b76f856fd7a759a355259b76ed mirage-0.8.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named and is cleanly written. + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc files. + no -devel subpackage exists + no .la files included. + translations are available. + scriptlets update-desktop-database is used. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed successfully + Desktop file is handled correctly in SPEC file. + GUI application + Followed Python packaging guidelines also. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review