Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226223 --- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-09-09 13:15:19 EDT --- Well, checking master head (2.14.18-2.fc15) * License - So, if you want to use "LGPLv2+ and GPLv2+" for license tag, please specify explicitly which part is LGPLv2+ and which part is GPLv2+. * Version specific BR - ">=" parts on BuildRequires's are no longer needed because packages on currently supported Fedora branches all satisfy these dependencies ( And especially I see no reason to keep writing these version specific BR on current rawhide ) https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires * Status of the patches - Please write the status of the patches (i.e. if the patch is to be merged into the upstream, or if it is Fedora specific, or something else). ! Especially, I guess maintainers of ORBit2 on Fedora also take part in GNOME Project, so I cannot guess why 2.14.3- patches are not yet merged into 2.14.18 tarball. https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment * Requires on -devel subpackage - Would you explain what "R: indent" is for? - "R: pkgconfig" "R: foo-devel" are no longer needed. These dependencies are automatically needed. ! And as I wrote above, I think keeping writing explicit version dependencies here makes no sense. * Duplicate %description - %description in -devel subpackage contains the same contents shown in the %description of the main package and it is redundant. * Timestamps - Please consider to add "INSTALL='install -p'" option to "make install" to keep timestamps on installed files as much as possible, especially on installed header files. * Static archive - Please take care of https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries - At least .a files must be split out from -devel subpackage * %check - As this package contains test/ directory, please add %check section and execute some test program (like $ make check ) there ! And (on my local machine) actually currently "make check" fails like ------------------------------------------------------------------------------- mem usage prev/post: 1388KB / 1464KB -- 1000x test_ORBit_alloc () ** ERROR:test-mem.c:239:main_func: assertion failed: (mem_usage_end - mem_usage_start < 50) /bin/sh: line 5: 30139 Aborted ${dir}$tst FAIL: test-mem .... .... 1 of 6 tests failed Please report to http://bugzilla.gnome.org/enter_bug.cgi?product=ORBit2 ------------------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review