[Bug 212916] Review Request: php-pear-DB-DataObject-FormBuilder - Automatically build HTML_QuickForm objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-DB-DataObject-FormBuilder - Automatically build HTML_QuickForm objects
Alias: DataObj-FormBuilder

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212916


tibbs@xxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs@xxxxxxxxxxx  2006-11-18 22:16 EST -------
The usual no-documentation warning:
  W: php-pear-DB-DataObject-FormBuilder no-documentation
I was browsing the PEAR site and I noticed that there is actually documentation
online for this package.  I wonder if it wouldn't be reasonable to include a
text file with at least some URLs in it:
 http://pear.reversefold.com/dokuwiki/doku.php?id=pear:db_dataobject_formbuilder
 http://opensource.21st.de/static/formbuilder/rapidprototyping-kr.pdf

* source files match upstream:
   0430207937449d635449389ae345854c  DB_DataObject_FormBuilder-1.0.0RC5.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
O rpmlint output is OK.
* final provides and requires are sane:
   php-pear(DB_DataObject_FormBuilder) = 1.0.0
   php-pear-DB-DataObject-FormBuilder = 1.0.0-0.1.RC5.fc7
  =
   /bin/sh
   /usr/bin/pear
   php-pear(DB_DataObject)
   php-pear(Date)
   php-pear(HTML_QuickForm)
   php-pear(HTML_Table)
   php-pear(PEAR)
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module installation)
* code, not content.
* no documentation, so no -docs subpackage is necessary.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]