Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630054 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-09-07 16:14:24 EDT --- About Patch0: --------------------------------------------------------- patch -p1 ./%{gemdir}/gems/facon-%{version}/spec/expectation_spec.rb < %{PATCH0} --------------------------------------------------------- - Please use defined %geminstdir macro also here. - It is preferable to use %patch0 macro like: ---------------------------------------------------------- pushd .%{geminstdir}/spec/ %patch0 -p0 ---------------------------------------------------------- ! Note that on Fedora %patchX macro adds some additional argument "-s --fuzz=0", especially %patchX checks if the patch can be applied with no fuzz. ------------------------------------------------------------- This package (rubygem-facon) is APPROVED by mtasaka ------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review