Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630754 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-07 04:18:38 EDT --- Hi Michael, here are some initial comments: - according to the source file headers, the license seems to be GPLv2+ (because of the addition "or (at your option) any later version") This must be reflected in the License field - you can drop Requires: gd since it's picked up automatically as a dependency - I suggest to run the tests coming with the tarball (add a %check section containing "make check") - please use macro %{_defaultdocdir} instead of %{_docdir} - in the %files section, replace the four %doc lines with %{_defaultdocdir}/%{name}-%{version}/ - replace %{_mandir}/man1/mscgen.1.gz with %{_mandir}/man1/mscgen.1* (because the compression method applied by rpmbuild might change) - In the %changelog section, you should only list changes made to the package/spec. Don't add the program's (upstream) changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review