Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services Alias: pear-Svcs-Weather https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-11-18 12:39 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - package licensed with open source compatible license - license matches actual license - spec written in American english X spec file is not legible, see comment #1 above. - sed command obfuscated by using comment character (#) as delimeter - source match upstream a83fbf5e2e7ffd22219c513cfefe6b52 Services_Weather-1.4.0.tgz - successfully compiles and builds on FC6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - not relocatable - owns all directories it creates - no duplicates in %files - file permissions set properly - contains proper %clean section - macro usage consistent - although you use %{__sed} when you dont use macros for any other system command - contains code - no large documentation - files in %doc do not affect run time - no header files or static libraries - no pkgconfig files - no devel subpackage required - no .la files - not a GUI app needing a .desktop file - does not own files or directories owned by other packages ==== MUST ==== - Unobfuscate sed command by using @ instead of # as delimiter (# is used as a comment character in spec files) ==== SHOULD ==== - Change %{__sed} to just "sed" to have consistent macro usage, macros for system commands are only needed for %post/%pre,%postun/%preun sections -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review