Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628202 --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-06 15:33:44 EDT --- Here are a couple of quick comments: - adapt the URL in Source0 according to http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net - the license seems to be GPLv3+ - add a comment to the spec file telling what the patch does - the %description lines should not exceed 80 characters - see http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files how to install locale files - development files (.h, .pc, .so if corresponding .so.* is present, ...) must go to a -devel subpackage, see https://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - you must call ldconfig in %post and %postun, see https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries - use macro %{_datadir} rather than %{_datarootdir} - add files COPYING, ChangeLog, CompatLog, README, README.audio with %doc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review