Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621015 --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-09-04 12:18:03 EDT --- For 2.1.6-1 * BR - So would you at least add "BR(check): rubygem(bcrypt-ruby)" (and "BR: rubygem(rake)" so as to make %check section pass correctly? Some additional notes * BuildRoot - BuildRoot tag is no longer used (and needed) on Fedora and EPEL6 https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * ri files generation - As I said in other review request (I suppose), usually we generate ri documentation files, which can be used with ri (in ruby-ri) command. * -doc files generation - And would you consider to create -doc subpackages and move document files (except for LICENSE, README.rdoc, CHANGELOG.rdoc) to -doc subpackage? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review