Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: beryl-dbus - Beryl OpenGL window and compositing manager dbus plug-in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215568 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-17 09:52 EST ------- Okay. ----------------------------------------------- This package (beryl-dbus) is APPROVED by me. ----------------------------------------------- Two comments. 1. Requires: dbus This is not necessary because this package (beryl-dbus) requires libdbus-1.so.3 and this adds dbus dependency automatically. 2. For beryl-core package: /usr/lib/libberylsettings.so.0.0.0 contains lots of undefined non-weak symbols (as said above). [tasaka1@localhost ~]$ ldd -r /usr/lib/libberylsettings.so.0.0.0 undefined symbol: g_free (/usr/lib/libberylsettings.so.0.0.0) undefined symbol: g_free (/usr/lib/libberylsettings.so.0.0.0) undefined symbol: g_slist_remove (/usr/lib/libberylsettings.so.0.0.0) undefined symbol: g_mkdir_with_parents (/usr/lib/libberylsettings.so.0.0.0) undefined symbol: g_key_file_has_key (/usr/lib/libberylsettings.so.0.0.0) undefined symbol: g_key_file_get_string_list (/usr/lib/libberylsettings.so.0.0.0) undefined symbol: g_dir_close (/usr/lib/libberylsettings.so.0.0.0) undefined symbol: XStringToKeysym (/usr/lib/libberylsettings.so.0.0.0) ....... ....... Please fix the linkage against this library. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review