Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625854 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Iain Arnell <iarnell@xxxxxxxxx> 2010-09-03 11:55:32 EDT --- + source files match upstream. da16c6a73f27ea5469c75f8cb47c24d2 CGI-Application-Plugin-CAPTCHA-0.01.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. - BuildRequires are proper. needs: perl(CGI::Application) perl(GD::SecurityImage) perl(HTTP::Server::Simple::CGI) should: perl(Test::Pod) perl(Test::Pod::Coverage) + compiler flags are appropriate. + %clean is present. - package builds in mock (with additional BRs above) http://koji.fedoraproject.org/koji/taskinfo?taskID=2445432 + package installs properly. + rpmlint has no complaints: perl-CGI-Application-Plugin-CAPTCHA.noarch: I: checking perl-CGI-Application-Plugin-CAPTCHA.noarch: I: checking-url http://search.cpan.org/dist/CGI-Application-Plugin-CAPTCHA/ (timeout 10 seconds) perl-CGI-Application-Plugin-CAPTCHA.src: I: checking perl-CGI-Application-Plugin-CAPTCHA.src: I: checking-url http://search.cpan.org/dist/CGI-Application-Plugin-CAPTCHA/ (timeout 10 seconds) perl-CGI-Application-Plugin-CAPTCHA.src: I: checking-url http://www.cpan.org/authors/id/C/CR/CROMEDOME/CGI-Application-Plugin-CAPTCHA-0.01.tar.gz (timeout 10 seconds) 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(CGI::Application::Plugin::CAPTCHA) = 0.01 perl-CGI-Application-Plugin-CAPTCHA = 0.01-1.fc15 = perl(Data::Random) perl(Exporter) perl(GD::SecurityImage) perl(:MODULE_COMPAT_5.12.1) perl(strict) perl(vars) + %check is present and all tests pass. All tests successful. Files=6, Tests=21, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.55 cusr 0.07 csys = 0.65 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. Add the missing BuildRequires and it's APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review