Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 Andrew Overholt <overholt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #41 from Andrew Overholt <overholt@xxxxxxxxxx> 2010-09-03 11:03:05 EDT --- (In reply to comment #40) > (In reply to comment #38) > > eclipse-photran.noarch: I: enchant-dictionary-not-found en_US > > > > No idea what's up here. > > You need to install hunspell-en and/or aspell-en I think. Correct you are :) > > eclipse-ptp.noarch: W: incoherent-version-in-changelog 4.0.3-0.2.v201009010938 > > ['4.0.3-0.2.RC2b.fc15', '4.0.3-0.2.RC2b'] > > > > Please fix this. > > Done. rpmlint can confirm that http://www.cora.nwra.com/~orion/fedora/eclipse-ptp.spec is fixed. > > As for the other rpmlint errors and warnings, I'm fine with the zero-length > > files if they're stubs but would like to see upstream queried as to why they're > > shipping them. The .c/.h files as you said are compiled on target machines so > > they're fine to ship as is. I wonder if upstream doesn't know about p2 > > touchpoints to do chmod operations ... either way, I don't see a big deal with > > the configure and various .sh scripts not having the execute bit set. > > I'll ping upstream about this. Great, thanks. > > eclipse-ptp.src: W: strange-permission finddeps.sh 0755L > > eclipse-ptp.src: W: strange-permission makesource.sh 0755L > > > > These are fine in my book since you use them to generate stuff for the build. > > > > eclipse-ptp.src: W: invalid-url Source0: org.eclipse.ptp-ptp_4_0.tar.gz > > > > I don't know what's wrong with this. > > It wants a url (e.g. http://....). We don't have one, but we document how to > generate the source tarball. Yeah, I just don't remember seeing that for other packages that have no full URLs like this. It's not a big deal. This package is approved. Thanks for the hard work, Orion! Please update https://fedoraproject.org/wiki/Features/F14EclipseHelios when it's built for F14 and rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review