Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617632 Ian Weller <ian@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #13 from Ian Weller <ian@xxxxxxxxxxxxx> 2010-09-02 16:54:21 EDT --- All outstanding issues have been resolved. (In reply to comment #12) > (In reply to comment #11) > > For the condrestart lines, I would assume that that's OK for this package, > > but > > I would also want to check explicitly with upstream to see if that makes > > sense. > > Sorry, can you elaborate on this a little more, I don't understand what I need > to clarify upstream. The guidelines state (at https://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_spec_file_scriptlets): "if [ "$1" -ge "1" ] checks that this is an upgrade of the package. If so, restart the service if it's running. (This may not be appropriate for all services.)" I just wanted to make sure that condrestart was appropriate for this service. It's not a blocker so you can deal with this later. --------------------------------------------------------- This package (openstack-swift) is APPROVED by ianweller --------------------------------------------------------- (Sorry for the hilariously long delay, getting used to scheduling things at college has been... interesting.) :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review