Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226569 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flag| |fedora-review+ --- Comment #8 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2010-09-02 14:30:59 EDT --- == Review == Good: - rpmlint checks return: xorg-sgml-doctools.src: W: no-cleaning-of-buildroot %install xorg-sgml-doctools.src: W: no-cleaning-of-buildroot %clean xorg-sgml-doctools.src: W: no-buildroot-tag xorg-sgml-doctools.src: W: no-%clean-section These are safe to ignore. xorg-sgml-doctools.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/xorg-sgml-doctools.pc Given that this package is really only useful for generating xorg docs, I think it falls into the following exception: "A reasonable exception is when the main package itself is a development tool not installed in a user runtime, e.g. gcc or gdb. " - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (0e135d7c848d8b740df71895aa00ed8354406979e01f0df50a243fcd46452e20) - package compiles on devel (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review