Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627877 --- Comment #7 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-09-02 12:44:53 EDT --- jibx.noarch: W: invalid-license BSD/ASL 1.1 jibx.noarch: W: no-documentation jibx.noarch: W: class-path-in-manifest /usr/share/java/jibx/extras-1.2.2.jar jibx.noarch: W: class-path-in-manifest /usr/share/java/jibx/bind-1.2.2.jar jibx.noarch: W: class-path-in-manifest /usr/share/java/jibx/run-1.2.2.jar jibx-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese jibx-javadoc.noarch: W: invalid-license BSD/ASL 1.1 jibx.src: W: invalid-license BSD/ASL 1.1 3 packages and 0 specfiles checked; 0 errors, 8 warnings. The license string should be "BSD and ASL 1.1" Class-path-in-manifest is there because of: <attribute name="Class-Path" ... lines in build/build.xml. These need to be patched out. This in turn will unfortunately make tests fails. We can discuss how to fix that on IRC again. Other: * This is not needed: > export OPT_JAR_LIST="`%{__cat} %{_sysconfdir}/ant.d/junit`" * You still have sed in the %build section (stax-api) * it is customary to leave blank lines between changelog versions and sections (your 2 file sections are merged) * Your Requires are still too big. Leave it at just java and jpackage-utils for now. * You should run for cycle in %install section for "schema" and "tools" subdirectory I know it sound like a lot of work (again), but you've done good job so far considering how much work this needs :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review