Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629443 --- Comment #2 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-09-02 04:53:50 EDT --- Few things first: * are you sponsored? If not akurtakov agreed to do the "official" review and sponsor you * You should really skim through https://fedoraproject.org/wiki/Packaging:Java Issues at first glance: * Javadoc sub-package also needs to have license files. * package and javadoc sub-package should have a Requires on jpackage-utils * You have to provide unversioned jar files too. This is most common way to do it during %install phase: (cd $RPM_BUILD_ROOT%{_javadir}/ && for jar in *-%{version}*; \ do ln -sf ${jar} `echo $jar| sed "s|-%{version}||g"`; done) * src/maven contains maven pom files. You should install these, and also use add_to_maven_depmap macro so that maven can find your jar files. See https://fedoraproject.org/wiki/Packaging:Java#maven for detais. It can be a bit tricky to get call to that macro right so don't hesitate to ask for help. * Package uses A LOT of bundled libraries. I haven't checked if they are all available in Fedora, but for using bundled libraries you would need to have a good reason and a FESCO exception to boot (not happening) * Your use of "build-classpath" is incorrect. Build-classpath is not automatic, you need to tell what jar file it should add to the classpath. Example use: $ build-classpath plexus/container-default /usr/share/java/plexus/container-default.jar In your case you will most probably have to do "build-jar-repository" (creates symlinks, not just outputs to stdout) and then modify build.xml probably because filenames will be a bit different than originals (version part missing). To make sure you are not using bundled libraries: "rm -rf lib/*" in %prep section of spec file. This means you will have to add them to BuildRequires and then modify build system to use symlinks created by build-jar-repository. That's all I could see, please make these changes and then we'll see what next. I case you need help getting something to work, ask here or stop by at fedora-java -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review