Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526567 --- Comment #24 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2010-08-31 09:12:11 EDT --- Sorry for long-delayed REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is almost silent work ~/Desktop: rpmlint mongodb-* mongodb.i686: W: spelling-error %description -l en_US sharding -> sharing, shading, sharping mongodb.i686: W: no-manual-page-for-binary bsondump Error checking signature of mongodb-debuginfo-1.6.0-1.fc13.i686.rpm: mongodb-debuginfo-1.6.0-1.fc13.i686.rpm: sha1 MD5 NOT OK mongodb-devel.i686: W: no-documentation mongodb-server.i686: W: spelling-error Summary(en_US) sharding -> sharing, shading, sharping mongodb-server.i686: W: spelling-error %description -l en_US sharding -> sharing, shading, sharping mongodb-server.i686: E: incoherent-logrotate-file /etc/logrotate.d/mongodb mongodb-server.i686: W: non-standard-uid /var/log/mongodb mongodb mongodb-server.i686: W: non-standard-uid /var/lib/mongodb mongodb mongodb-server.i686: W: incoherent-init-script-name mongod ('mongodb-server', 'mongodb-serverd') 4 packages and 0 specfiles checked; 1 errors, 8 warnings. work ~/Desktop: All these messages are either bogus or already explained by Ionuț. + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. -/+ The package doesn't fully meet the Packaging Guidelines. It doesn't use Fedora-specific CFLAGS/CXXFLAGS. This must be fixed. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source: Sulaco ~/rpmbuild/SOURCES: sha256sum mongodb-src-r1.6.0.tar.gz* a81cb6445e003d6e73a983336855ddadf0ae4334d49f3a5ce6757d1261bd4c77 mongodb-src-r1.6.0.tar.gz a81cb6445e003d6e73a983336855ddadf0ae4334d49f3a5ce6757d1261bd4c77 mongodb-src-r1.6.0.tar.gz.1 Sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. http://koji.fedoraproject.org/koji/taskinfo?taskID=2437186 + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No subpackages which stores shared library files (not just symlinks) in any of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries (also see Ionuț's note about bson above). 0 The package isn't designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. - The package must consistently use macros while you're currently mixing macros instead of core utilities somewhere and real names. Namely I mean %{__sed} and %{__chmod} macros. I suggest you to use plain sed and chmod instead. + The package contains code, or permissible content. 0 No extremely large documentation files. + Everything, the package includes as %doc, does not affect the runtime of the application. + Header files are in a -devel package. +/- Static libraries must be in a -static package as stated in Fedora Packaging Guidelines. However I'm not sure here since this package doesn't have any shared libraries at all. So I believe that adding necessary Provides is enough. 0 No libraries files with a suffix (e.g. libfoo.so.1.1). +/- The devel sub-package requires the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}. Again I'm not sure here because I don't know much about mongodb and its environment for developers, but I'm suspecting that main package isn't required for development. Anyway, adding one excessive explicit requirement doesn't break anything. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The packages does not own files or directories already owned by other packages. + All filenames in the packages are valid UTF-8. Ok, summarizing things: * Please, fix scons-makefiles to use Fedora-specific CFLAGC/CXXFLAGC. * Consider removing useless macros such for sed and chmod * Version 1.6.1 is available. Consider upgrading. * Do you plan to provide rpm for EL-5? If yes, then, please, uncomment the only string in the %clean section. I don't see any other issues, so, please, comment these notes, and I'll continue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review