Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 orion@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orion@xxxxxxxxxxxxx OtherBugsDependingO|163776, 177841 |163778 nThis| | ------- Additional Comments From orion@xxxxxxxxxxxxx 2006-11-16 16:21 EST ------- Initial comments: - BAD: md5sum does not match upstream. - Need full URL for source (http://prdownloads.sf.net/limph/limph-%{version}.tar.gz - Please, BuildArch: not BuildArchitectures: $ rpmlint ~/Desktop/limph-1.9.3-1.src.rpm W: limph strange-permission limph-hostagent 0755 - perhaps just change the permission with "install"? E: limph use-of-RPM_SOURCE_DIR - Instead of "$RPM_SOURCE_DIR/limph.conf", use %SOURCE1, etc. - should add to limph.conf: <Directory /usr/share/limph/> Order Deny,Allow Deny from all Allow from 127.0.0.1 </Directory> - More rpmlint: # rpmlint limph E: limph file-in-usr-marked-as-conffile /usr/share/limph/config.php E: limph file-in-usr-marked-as-conffile /usr/share/limph/input.php - move to /etc/limph. Is input.php really a config file? E: limph world-writable /usr/share/limph/tmp 0777 E: limph non-standard-dir-perm /usr/share/limph/tmp 0777 - These should only be writable by limph. # rpmlint limph-hostagent E: limph-hostagent file-in-usr-marked-as-conffile /usr/share/limph/host_agent.php - same here. Maybe put $secret into a config file in /etc/limph and include that? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review