Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #10 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-08-31 03:47:39 EDT --- Hi Ralph, your package looks almost fine now. Just a couple of things to consider: - please adapt the URL in Source0 according to https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net - in the %changelog section, replace %doc with %%doc to make rpmlint happy (see rpmlint output below) - I recommend to be a bit more specific in %files and replace %{_mandir}/man1/procServ.* with %{_mandir}/man1/procServ.1* The latter might seem a bit nit-picking, but it helps to avoid adding files in wrong places. I already came across packages with man3 files in man1 folders. When using an explicit suffix, something like that won't happen by accident in future releases. BTW, if you don't have a sponsor yet, I'm willing to sponsor you. $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm procServ.src: W: spelling-error %description -l en_US conserver -> conserve, conserves, conserved procServ.src: W: spelling-error %description -l en_US localhost -> local host, local-host, localism procServ.src:48: W: macro-in-%changelog %doc procServ.x86_64: W: spelling-error %description -l en_US conserver -> conserve, conserves, conserved procServ.x86_64: W: spelling-error %description -l en_US localhost -> local host, local-host, localism 3 packages and 0 specfiles checked; 0 errors, 5 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review